umamaheswararao commented on a change in pull request #2910:
URL: https://github.com/apache/ozone/pull/2910#discussion_r769090673
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -303,13 +327,40 @@ private StripeWriteStatus handleParityWrites(int
parityCellSize,
if (allocateBlockIfFull) {
blockOutputStreamEntryPool.allocateBlockIfNeeded();
}
+ currentBlockGroupLen = 0;
} else {
streamEntry.resetToFirstEntry();
}
- currentBlockGroupLen = 0;
+
return StripeWriteStatus.SUCCESS;
}
+ private boolean isDataWriteSuccess() {
Review comment:
I changed the method names. Even though we are operating on the
ECBlockOutputStreamEntryPool data structures, the usage logic should be in
output stream for better readability. Especially I don;t want adding into
excludeLists logic to be hidden somewhere in other classes. Ideally
ECBlockOutputStreamEntryPool should be used as pool for keeping the entries,
but we added some additional logics to it.
But I agree that method names can be changed, so that we don't need to
negate in if checks. Let me know if you still feel concerned on this, we can
discuss and move forward on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
