tanvipenumudy commented on code in PR #3271:
URL: https://github.com/apache/ozone/pull/3271#discussion_r844611379
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java:
##########
@@ -195,18 +202,28 @@ private boolean lock(Resource resource, String
resourceName,
}
}
- private void updateReadLockMetrics(Resource resource, String lockType,
+ private void updateReadLockMetrics(Resource resource,
long startWaitingTimeNanos) {
- if (lockType.equals(READ_LOCK)) {
- long readLockWaitingTimeNanos =
- Time.monotonicNowNanos() - startWaitingTimeNanos;
+ long readLockWaitingTimeNanos =
+ Time.monotonicNowNanos() - startWaitingTimeNanos;
- // Adds a snapshot to the metric readLockWaitingTimeMsStat.
- omLockMetrics.setReadLockWaitingTimeMsStat(
- TimeUnit.NANOSECONDS.toMillis(readLockWaitingTimeNanos));
+ // Adds a snapshot to the metric readLockWaitingTimeMsStat.
+ omLockMetrics.setReadLockWaitingTimeMsStat(
+ TimeUnit.NANOSECONDS.toMillis(readLockWaitingTimeNanos));
- resource.setStartHeldTimeNanos(Time.monotonicNowNanos());
- }
+ resource.setStartHeldTimeNanos(Time.monotonicNowNanos());
+ }
+
+ private void updateWriteLockMetrics(Resource resource,
+ long startWaitingTimeNanos) {
+ long writeLockWaitingTimeNanos =
+ Time.monotonicNowNanos() - startWaitingTimeNanos;
+
+ // Adds a snapshot to the metric writeLockWaitingTimeMsStat.
+ omLockMetrics.setWriteLockWaitingTimeMsStat(
+ TimeUnit.NANOSECONDS.toMillis(writeLockWaitingTimeNanos));
+
+ resource.setStartHeldTimeNanos(Time.monotonicNowNanos());
Review Comment:
Thank you for the comment, I have incorporated the changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
