tanvipenumudy commented on code in PR #3271:
URL: https://github.com/apache/ozone/pull/3271#discussion_r844637577
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneManagerLock.java:
##########
@@ -426,8 +444,58 @@ public void testReadLockConcurrentStats() throws
InterruptedException {
String readHeldStat = lock.getReadLockHeldTimeMsStat();
Assert.assertTrue(
- "Expected " + threadCount + " samples in " + readHeldStat,
+ "Expected " + threadCount +
+ " samples in readLockHeldTimeMsStat: " + readHeldStat,
readHeldStat.contains("Samples = " + threadCount));
+
+ String readWaitingStat = lock.getReadLockWaitingTimeMsStat();
+ Assert.assertTrue(
+ "Expected " + threadCount +
+ " samples in readLockWaitingTimeMsStat: " + readWaitingStat,
+ readWaitingStat.contains("Samples = " + threadCount));
+ }
+ }
+
+ @Test
+ public void testWriteLockConcurrentStats() throws InterruptedException {
Review Comment:
Thank you for the comment, added
`testSyntheticReadWriteLockConcurrentStats()` to produce a mix of multiple
readers + writers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
