neils-dev commented on code in PR #3297:
URL: https://github.com/apache/ozone/pull/3297#discussion_r849685259
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java:
##########
@@ -65,6 +64,8 @@ public void initializeMemberVariables() {
xmlPrefixToSkipCompare.add("ipc.client.rpc-timeout.ms");
xmlPropsToSkipCompare.add("ozone.om.leader.election.minimum.timeout" +
".duration"); // Deprecated config
+ xmlPrefixToSkipCompare.add("ozone.s3g");
+ configurationPrefixToSkipCompare.add("ozone.s3g");
Review Comment:
Yes, all S3 config keys are skipped in the integration test. This ensures
that the `ozone-s3gateway` jar is not in the classpath for the integration
tests. This was introduced in #2485 "_Specifically, integrations tests are now
intentionally independent of s3g implementation through modified pom files and
configuration tests._".
(Since there are no s3 gateway integration tests (s3gateway tested through
acceptance tests), the `ozone-s3gateway `does not need to be in the the
classpath.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
