adoroszlai commented on code in PR #3297:
URL: https://github.com/apache/ozone/pull/3297#discussion_r849692594
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java:
##########
@@ -65,6 +64,8 @@ public void initializeMemberVariables() {
xmlPrefixToSkipCompare.add("ipc.client.rpc-timeout.ms");
xmlPropsToSkipCompare.add("ozone.om.leader.election.minimum.timeout" +
".duration"); // Deprecated config
+ xmlPrefixToSkipCompare.add("ozone.s3g");
+ configurationPrefixToSkipCompare.add("ozone.s3g");
Review Comment:
This one is a special sanity test it verifies that config properties keys
are present in both XML and Java. Ignoring all S3-specific keys is a potential
source of mismatch.
This test is not needed for config defined with `@Config` annotations, so we
may be able to alleviate the problem by moving from XML to the annotation-based
approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
