neils-dev commented on code in PR #3297:
URL: https://github.com/apache/ozone/pull/3297#discussion_r857852173
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java:
##########
@@ -65,6 +64,8 @@ public void initializeMemberVariables() {
xmlPrefixToSkipCompare.add("ipc.client.rpc-timeout.ms");
xmlPropsToSkipCompare.add("ozone.om.leader.election.minimum.timeout" +
".duration"); // Deprecated config
+ xmlPrefixToSkipCompare.add("ozone.s3g");
+ configurationPrefixToSkipCompare.add("ozone.s3g");
Review Comment:
Thanks for following up on removing `S3GatewayConfigKeys` with the
associated integration test, TestOzoneConfigurationKeys @adoroszlai. Doing so
allows us to remove the `ozone-s3gateway` jar from the integration test
classpath.
> Can you please let me know why the dependency would need to be removed?
The change was made to remove the `ozone-s3gateway `dependency from the
integration test classpath (we can do away with including the `ozone-s3gateway`
from the pom build file for the integration tests). This was needed because
initially with the `OmTransportFactory` selecting the `OmTransport` through
the` ServiceProvider`. In the case of the integration tests, the
`ServiceProvider` was dynamically instantiating the `GrpcOmTransport` for
**_all_** OzoneClients since it found the `ozone-s3gateway` in the classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
