neils-dev commented on code in PR #3297:
URL: https://github.com/apache/ozone/pull/3297#discussion_r858046537
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java:
##########
@@ -65,6 +64,8 @@ public void initializeMemberVariables() {
xmlPrefixToSkipCompare.add("ipc.client.rpc-timeout.ms");
xmlPropsToSkipCompare.add("ozone.om.leader.election.minimum.timeout" +
".duration"); // Deprecated config
+ xmlPrefixToSkipCompare.add("ozone.s3g");
+ configurationPrefixToSkipCompare.add("ozone.s3g");
Review Comment:
In checking the integration tests and potential problems resulting from
including the ozone-s3gateway in the integration tests classpaths, currently
there are no problems. However there is a case where it can cause problems.
The case where the service loader dynamically instantiates the GrpcOmTransport
for integration tests currently occurs when the default
`ozone.om.transport.class` config key is _mis-configured_ to
`GrpcOmTransportFactory`.
When the OmConfigKeys is incorrectly set to ,
OZONE_OM_TRANSPORT_CLASS_DEFAULT =
"org.apache.hadoop.ozone.om.protocolPB".GrpcOmTransportFactory", it results in
all OzoneClient requests using the GrpcOmTransport, failing tests such as
`TestOzoneRpcClient`.
We can ensure that integration tests pass with the **_default_** config
mis-configured by adding a` META-INF.services` for `ServiceProvider` to use
hadoopOmTransport and overriding the _ozone.om.transport.class_ in the
integration tests local _ozone-site.xml_ file. Is this necessary or should we
fail the integration tests if the _**default**_ _ozone.om.transport.class_ is
set incorrectly in the OMConfigKeys?
We can have the `TestOzoneConfigurationKeys` include s3 gateway checks
provided we ensure the tests pass if configuration keys are mis-configured or
we simply fail if incorrectly set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
