adoroszlai commented on code in PR #3297:
URL: https://github.com/apache/ozone/pull/3297#discussion_r857913657
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java:
##########
@@ -65,6 +64,8 @@ public void initializeMemberVariables() {
xmlPrefixToSkipCompare.add("ipc.client.rpc-timeout.ms");
xmlPropsToSkipCompare.add("ozone.om.leader.election.minimum.timeout" +
".duration"); // Deprecated config
+ xmlPrefixToSkipCompare.add("ozone.s3g");
+ configurationPrefixToSkipCompare.add("ozone.s3g");
Review Comment:
Reading `OmTransportFactory` code, it should load dynamically via
`ServiceLoader` only if `ozone.om.transport.class` is not set to the default
one (`Hadoop3OmTransportFactory`). I don't think integration tests would use
`GrpcOmTransport`, unless we override this config in
`hadoop-ozone/integration-test/src/test/resources/ozone-site.xml` or in
individual test classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
