krishnaasawa1 commented on code in PR #4557:
URL: https://github.com/apache/ozone/pull/4557#discussion_r1163865854
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/RocksDBStoreMetrics.java:
##########
@@ -105,6 +105,8 @@ public class RocksDBStoreMetrics implements MetricsSource {
private static final String NUM_FILES_AT_LEVEL = "num_files_at_level";
private static final String SIZE_AT_LEVEL = "size_at_level";
+ private static final String LAST_SEQUENCE_NUMBER = "last_sequence_number";
Review Comment:
Looks straightforward change introducing LAST_SEQUENCE_NUMBER metrics. On
similar lines as HistogramData,TickerTypeData,PropertyData we have introduced
getLatestSequenceNumber and updating metrics with calling
getLatestSequenceNumber via getMetrics.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/RocksDBStoreMetrics.java:
##########
@@ -105,6 +105,8 @@ public class RocksDBStoreMetrics implements MetricsSource {
private static final String NUM_FILES_AT_LEVEL = "num_files_at_level";
private static final String SIZE_AT_LEVEL = "size_at_level";
+ private static final String LAST_SEQUENCE_NUMBER = "last_sequence_number";
Review Comment:
@mohammadjkhan @devmadhuu Please Review as metrics related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
