ChenSammi commented on PR #4557: URL: https://github.com/apache/ozone/pull/4557#issuecomment-1511056448
> Prod code LGTM, is there any scope to extend a test as well, may be just verifying this number gets populated? @ayushtkn , Unfortunately, there is no metrics related integration test in Ozone now. The patch is tested by starting a single node cluster, and fetch the /jmx content of service. We can add the metrics integration test in a follow up JIRA [HDDS-8432](https://issues.apache.org/jira/browse/HDDS-8432). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
