lxy-9602 commented on code in PR #284:
URL: https://github.com/apache/paimon-cpp/pull/284#discussion_r3954708382
##########
src/paimon/core/operation/file_store_scan.cpp:
##########
@@ -376,7 +376,7 @@ Status FileStoreScan::ReadManifestEntriesWithCache(
std::shared_ptr<CacheKey>
FileStoreScan::SnapshotLiveManifestEntriesCacheKey(int32_t bucket) const {
if (!bucket_filter_ && bucket_selector_) {
- return CreateInferredSnapshotLiveManifestEntriesCacheKey(
+ return paimon::SnapshotLiveManifestEntriesCacheKey::ForInferred(
table_path_,
BranchManager::NormalizeBranch(core_options_.GetBranch()), bucket,
Review Comment:
In `src`, we probably don’t need the `paimon::` qualifier here? Also, can
`CacheKey::ForSnapshotLiveManifestEntries` be removed directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
