wangyong9999 commented on code in PR #284:
URL: https://github.com/apache/paimon-cpp/pull/284#discussion_r3955343335
##########
src/paimon/core/operation/file_store_scan.cpp:
##########
@@ -376,7 +376,7 @@ Status FileStoreScan::ReadManifestEntriesWithCache(
std::shared_ptr<CacheKey>
FileStoreScan::SnapshotLiveManifestEntriesCacheKey(int32_t bucket) const {
if (!bucket_filter_ && bucket_selector_) {
- return CreateInferredSnapshotLiveManifestEntriesCacheKey(
+ return paimon::SnapshotLiveManifestEntriesCacheKey::ForInferred(
table_path_,
BranchManager::NormalizeBranch(core_options_.GetBranch()), bucket,
Review Comment:
Done in e918bd48. Removed the public forwarding factory and switched its
callers to the internal factories. Renamed the scan helper to
CreateSnapshotLiveManifestEntriesCacheKey so it no longer shadows the key
class, then removed the paimon:: qualifier. The PR description notes the public
API removal. Build, 56 core tests, 15 cache tests and 81 integration tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
