tustvold commented on code in PR #244:
URL: https://github.com/apache/parquet-format/pull/244#discussion_r1608170678
##########
src/main/thrift/parquet.thrift:
##########
@@ -578,7 +578,13 @@ enum BoundaryOrder {
/** Data page header */
struct DataPageHeader {
- /** Number of values, including NULLs, in this data page. **/
+ /**
+ * Number of values, including NULLs, in this data page.
+ *
+ * If a ColumnIndex is present, a page must begin at a record
+ * boundary (repetition_level = 0). Otherwise, pages may begin
+ * within a record (repetition_level > 0).
Review Comment:
I wonder if we could instead state that records should not be split across
pages, but that readers should tolerate this in the abscence of a page index or
v2 data pages, as certain writers historically wrote such data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
