alamb commented on code in PR #244:
URL: https://github.com/apache/parquet-format/pull/244#discussion_r1620514862
##########
src/main/thrift/parquet.thrift:
##########
@@ -578,7 +578,13 @@ enum BoundaryOrder {
/** Data page header */
struct DataPageHeader {
- /** Number of values, including NULLs, in this data page. **/
+ /**
+ * Number of values, including NULLs, in this data page.
+ *
+ * If a OffsetIndex is present, a page must begin at a record
Review Comment:
Mailing list conversation:
https://lists.apache.org/thread/0gxjk4tphxls0gcrc7lt775pf8s7gtz3
Currently the consensus seems to be to use "row"
I will make a follow on PR to change that terminology after this PR is
merged.
I would like to retain the "record" terminology here to remain consistent
with the current wording in the repetition levels section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
