etseidl commented on code in PR #244:
URL: https://github.com/apache/parquet-format/pull/244#discussion_r1608899535


##########
src/main/thrift/parquet.thrift:
##########
@@ -995,8 +1005,9 @@ struct PageLocation {
   2: required i32 compressed_page_size
 
   /**
-   * Index within the RowGroup of the first row of the page; this means pages
-   * change on record boundaries (r = 0).
+   * Index within the RowGroup of the first row of the page. When a
+   * ColumnIndex is present, pages begin on record boundaries

Review Comment:
   ```suggestion
      * Index within the RowGroup of the first row of the page. When an
      * OffsetIndex is present, pages must begin on record boundaries
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to