wgtmac commented on code in PR #464:
URL: https://github.com/apache/parquet-format/pull/464#discussion_r1821738484
##########
VariantEncoding.md:
##########
@@ -391,6 +391,10 @@ The Decimal type contains a scale, but no precision. The
implied precision of a
| Float | float | `14` | FLOAT
| IEEE little-endian
|
| Binary | binary | `15` | BINARY
| 4 byte little-endian size, followed by bytes
|
| String | string | `16` | STRING
| 4 byte little-endian size, followed by UTF-8 encoded bytes
|
+| TimeNTZ | time without time zone | `21` | TIME(false,
MICROS) | 8-byte little-endian
|
+| Timestamp_ns | timestamp | `22` |
TIMESTAMP(true, NANOS) | 8-byte little-endian
|
Review Comment:
I know that iceberg has added `timestamp_ns` in the V3 spec. From the
Parquet side, we'd better be more generic. Should we consider parameterized
timestamp type like what Trino does for Variant type:
https://trino.io/docs/current/language/types.html#timestamp-p?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
