Fokko commented on code in PR #464:
URL: https://github.com/apache/parquet-format/pull/464#discussion_r1824436646
##########
VariantEncoding.md:
##########
@@ -391,6 +391,10 @@ The Decimal type contains a scale, but no precision. The
implied precision of a
| Float | float | `14` | FLOAT
| IEEE little-endian
|
| Binary | binary | `15` | BINARY
| 4 byte little-endian size, followed by bytes
|
| String | string | `16` | STRING
| 4 byte little-endian size, followed by UTF-8 encoded bytes
|
+| TimeNTZ | time without time zone | `21` | TIME(false,
MICROS) | 8-byte little-endian
|
+| Timestamp_ns | timestamp | `22` |
TIMESTAMP(true, NANOS) | 8-byte little-endian
|
Review Comment:
I very much agree here. This is also in line with the
[LogicalTypeAnnotation](https://github.com/apache/parquet-java/blob/73a4430af6c40f8eb246ad4911eb6d103c9a2abe/parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java#L601)
in `parquet-java`.
```suggestion
| Timestamp | timestamp | `22` |
TIMESTAMP(isAdjustedToUTC=true, NANOS) | 8-byte little-endian
|
```
Since this hasn't been published yet, I would also propose:
- Group these with the other timestamp/time types.
- Remove the NTZ, as it is similar to the timeunit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
