aihuaxu commented on code in PR #464:
URL: https://github.com/apache/parquet-format/pull/464#discussion_r1826020123
##########
VariantEncoding.md:
##########
@@ -391,6 +391,10 @@ The Decimal type contains a scale, but no precision. The
implied precision of a
| Float | float | `14` | FLOAT
| IEEE little-endian
|
| Binary | binary | `15` | BINARY
| 4 byte little-endian size, followed by bytes
|
| String | string | `16` | STRING
| 4 byte little-endian size, followed by UTF-8 encoded bytes
|
+| TimeNTZ | time without time zone | `21` | TIME(false,
MICROS) | 8-byte little-endian
|
+| Timestamp_ns | timestamp | `22` |
TIMESTAMP(true, NANOS) | 8-byte little-endian
|
Review Comment:
Thanks for reviewing. I will try to make the name change to align with
Parquet annotation The only thing is that we need to have separate type ID for
ltz/ntz and micro/nano seconds. so it would be cleaner to have them into
separate entries rather than grouping them with parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
