divjotarora commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3415946314
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -447,6 +451,35 @@ public ParquetFileWriter(
props.getAllocator());
}
+ /**
+ * Returns the schema with INT96 columns tagged with the
INT96_TIMESTAMP_ORDER column order if
+ * INT96 timestamp statistics are enabled, so that statistics are
accumulated with the
+ * chronological comparator and the proper column order is written to the
footer.
+ */
+ static MessageType applyInt96TimestampOrder(MessageType schema,
ParquetProperties props) {
Review Comment:
Yep, all of this was removed along with removing the writer-side flag
because we can just construct the `PrimitiveType` with the order now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
