rdblue commented on code in PR #584:
URL: https://github.com/apache/parquet-format/pull/584#discussion_r3454665007
##########
src/main/thrift/parquet.thrift:
##########
@@ -1195,6 +1198,18 @@ union ColumnOrder {
* or max_values indicates that all non-null values are NaN.
*/
2: IEEE754TotalOrder IEEE_754_TOTAL_ORDER;
+
+ /*
+ * The INT96 timestamp type is ordered chronologically. Only columns of
+ * physical type INT96 may use this ordering.
+ *
+ * When writing statistics for columns with INT96_TIMESTAMP_ORDER, two values
+ * must be compared as follows:
Review Comment:
Is this necessary? I would prefer not over-specifying how to compare two
serialized values and would rather rely on the "ordered chronologically"
statement above. The only reason I would include this is if we don't have
requirements written down for INT96 timestamps, in which case this could not
rely on that serialization and chronological order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
