rdblue commented on code in PR #584:
URL: https://github.com/apache/parquet-format/pull/584#discussion_r3455492334
##########
src/main/thrift/parquet.thrift:
##########
@@ -1195,6 +1198,18 @@ union ColumnOrder {
* or max_values indicates that all non-null values are NaN.
*/
2: IEEE754TotalOrder IEEE_754_TOTAL_ORDER;
+
+ /*
+ * The INT96 timestamp type is ordered chronologically. Only columns of
+ * physical type INT96 may use this ordering.
+ *
+ * When writing statistics for columns with INT96_TIMESTAMP_ORDER, two values
+ * must be compared as follows:
Review Comment:
I still strongly prefer removing this. This is not the right place to
document how to interpret bytes of an INT96 to be a timestamp.
This also creates problems when there are bad values that violate the
assumptions made here. For instance, what happens when the first 8 bytes are
greater than the number of nanos in a day? What about negative values?
The rules here could produce incorrect results for presumably valid data
values. I prefer to stick to "ordered chronologically".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
