rok commented on code in PR #603:
URL: https://github.com/apache/parquet-format/pull/603#discussion_r3815388953


##########
LogicalTypes.md:
##########
@@ -736,7 +737,7 @@ set:
 
 | `inline` | `uri` | `offset` | `size` | Resolves to                           
    |
 
|----------|-------|----------|--------|-------------------------------------------|
-| set      | any   | any      | any    | the inline bytes                      
    |
+| set      | any   | any      | any    | the inline bytes (same as any 
locator)    |

Review Comment:
   This is now in contradiction with text below (line 769-772):
   
   * `offset` may only be set together with `uri`. A value that sets `offset` 
without `uri`
     does not resolve and is invalid.
   * `size` must be set whenever `offset` is set. A value that sets `offset` 
without `size`
     is invalid.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to