alkis commented on code in PR #603:
URL: https://github.com/apache/parquet-format/pull/603#discussion_r3823289383
##########
LogicalTypes.md:
##########
@@ -736,7 +737,7 @@ set:
| `inline` | `uri` | `offset` | `size` | Resolves to
|
|----------|-------|----------|--------|-------------------------------------------|
-| set | any | any | any | the inline bytes
|
+| set | any | any | any | the inline bytes (same as any
locator) |
Review Comment:
Good catch, that was a real contradiction. `inline` set with `offset` but no
`uri` was legal per the table and invalid per the bullets. Fixed in ed8bb0b —
the locator cells in that row are now marked `†` with a footnote:
> † Any combination of the locator fields that is valid on its own. A
locator set alongside `inline` must satisfy the same rules as one used on its
own, so `offset` requires `uri` and `size`.
So `inline` no longer relaxes the locator rules, it just takes precedence
for resolution. The bullets are unchanged and are now the single statement of
those rules.
##########
LogicalTypes.md:
##########
@@ -639,10 +639,10 @@ are found during reading, they must be ignored.
### FILE
-`FILE` annotates a group that represents a reference to a range of bytes,
which may
-be stored inline in the value, elsewhere within the current file, or in an
external file. It
-is intended for use cases such as storing file inventories, manifests, and
unstructured
-data references (e.g., images or audio files stored in object storage).
+`FILE` annotates a group that represents a reference to a range of bytes,
which may be
+stored inline in the value or in an external file. It is intended for use
cases such as
Review Comment:
Applied in ed8bb0b, and reflowed the paragraph.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
