Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/336#discussion_r212550265
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixPreparedStatement.java
 ---
    @@ -45,7 +45,9 @@ public ResultSet executeQuery() throws SQLException {
     
         @Override
         public ResultSet getResultSet() throws SQLException {
    -        return new LoggingPhoenixResultSet(super.getResultSet(), 
phoenixMetricsLog, sql);
    +        ResultSet resultSet = super.getResultSet();
    +        return (resultSet == null) ? null : new 
LoggingPhoenixResultSet(super.getResultSet(),
    --- End diff --
    
    This is still a bug. `super.getResultSet()` call is not idempotent. You 
should replace this with `resultSet` local variable


---

Reply via email to