Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/336#discussion_r212756649
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
---
@@ -91,19 +125,19 @@ public void testPhoenixMetricsLoggedOnCommit() throws
Exception {
// Assert that metrics logging happens only once
loggedConn.close();
- assertTrue("Mutation write metrics are not logged again.",
- mutationWriteMetricsMap.size() == 0);
- assertTrue("Mutation read metrics are not logged again.",
- mutationReadMetricsMap.size() == 0);
+ assertTrue("Mutation write metrics are not logged again.",
mutationWriteMetricsMap.size()
--- End diff --
nit: unnecessary diff (in lot of places)
---
