Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/336#discussion_r212757022
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixPreparedStatement.java
---
@@ -45,7 +45,9 @@ public ResultSet executeQuery() throws SQLException {
@Override
public ResultSet getResultSet() throws SQLException {
- return new LoggingPhoenixResultSet(super.getResultSet(),
phoenixMetricsLog, sql);
+ ResultSet resultSet = super.getResultSet();
--- End diff --
nit: add a comment that call to `getResultSet()` is not idempotent. Hence
we cache and return accordingly.
---
