yanxinyi commented on a change in pull request #916:
URL: https://github.com/apache/phoenix/pull/916#discussion_r504227350
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -2621,6 +2625,13 @@ private MetaDataMutationResult doDropTable(byte[] key,
byte[] tenantId, byte[] s
List<ImmutableBytesPtr> invalidateList = new
ArrayList<ImmutableBytesPtr>();
invalidateList.add(cacheKey);
PTable table = getTableFromCache(cacheKey, clientTimeStamp,
clientVersion);
+
+ // Disallow if the parent has PHOENIX_TTL set.
+ if (parentTable != null && parentTable.getPhoenixTTL() !=
PHOENIX_TTL_NOT_DEFINED) {
Review comment:
just want to confirm that we don't support more than 2 level case. For
example, we have a global view V1 of the TTL set. The V2 is a view on top of
the V1. If we create a new V3 on of the v2 with a TTL value, this won't catch
and allow the V3 view to have a TTL value, which might conflict with V1 TTL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
