jpisaac commented on a change in pull request #916:
URL: https://github.com/apache/phoenix/pull/916#discussion_r512392228
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -2639,6 +2646,20 @@ private MetaDataMutationResult doDropTable(byte[] key,
byte[] tenantId, byte[] s
QueryServices.ALLOW_SPLITTABLE_SYSTEM_CATALOG_ROLLBACK);
}
}
+ if (settingNewPhoenixTTLAttribute(tableMetadata,
PHOENIX_TTL_BYTES)) {
+ // Disallow if the parent has PHOENIX_TTL set.
+ if (parentTable != null && parentTable.getPhoenixTTL() !=
PHOENIX_TTL_NOT_DEFINED) {
+ isSchemaMutationAllowed = false;
+ }
+
+ // Since we do not allow propagation of PHOENIX_TTL values
during ALTER for now.
+ // If a child view exists and the parent previously had a
PHOENIX_TTL value set then that
+ // implies that the child view too has a valid PHOENIX_TTL
(non zero).
+ // In this case we do not allow for ALTER of the parent view
PHOENIX_TTL value.
+ if (!childViews.isEmpty()) {
Review comment:
Will change the comment to be less confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
