jpisaac commented on a change in pull request #916:
URL: https://github.com/apache/phoenix/pull/916#discussion_r512394047



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -2077,6 +2077,13 @@ private PTable createTableInternal(CreateTableStatement 
statement, byte[][] spli
                     }
                 }
 
+                // Cannot set PHOENIX_TTL if parent has already defined it.
+                if (tableType == VIEW  && parent != null && 
parent.getPhoenixTTL() != PHOENIX_TTL_NOT_DEFINED) {

Review comment:
       This check is during the createTable flow. Moreover the current code 
does not allow for easy client-side checks for TableProperty changes during 
alter command.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to