[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217043#comment-17217043 ]
ASF GitHub Bot commented on PHOENIX-6193: ----------------------------------------- stoty commented on pull request #925: URL: https://github.com/apache/phoenix/pull/925#issuecomment-712391531 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 3m 38s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 33m 36s | master passed | | +1 :green_heart: | compile | 1m 19s | master passed | | +1 :green_heart: | javadoc | 1m 28s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 18m 8s | the patch passed | | +1 :green_heart: | compile | 1m 16s | the patch passed | | +1 :green_heart: | javac | 1m 16s | the patch passed | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | shelldocs | 0m 1s | There were no new shelldocs issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | xml | 0m 9s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 0m 10s | phoenix-assembly in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 99m 22s | root in the patch failed. | | -1 :x: | asflicense | 1m 52s | The patch generated 8 ASF License warnings. | | | | 166m 4s | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-925/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/925 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit xml compile | | uname | Linux d93ab81a4843 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 5b58d9b | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-925/2/artifact/yetus-general-check/output/whitespace-eol.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-925/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-925/2/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-925/2/testReport/ | | asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-925/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 6701 (vs. ulimit of 30000) | | modules | C: phoenix-client-parent/phoenix-client phoenix-assembly phoenix-client-parent/phoenix-client-embedded . phoenix-client phoenix-client-parent U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-925/2/console | | versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > PHOENIX-6151 slows down shading > -------------------------------- > > Key: PHOENIX-6193 > URL: https://issues.apache.org/jira/browse/PHOENIX-6193 > Project: Phoenix > Issue Type: Bug > Components: core > Affects Versions: 5.1.0, 4.16.0 > Reporter: Istvan Toth > Assignee: Istvan Toth > Priority: Critical > Fix For: 5.1.0, 4.16.0 > > > PHOENIX-6151 increases shading time by ~400%, which is a disproportional > share of the total build time. -- This message was sent by Atlassian Jira (v8.3.4#803005)