[ https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217313#comment-17217313 ]
ASF GitHub Bot commented on PHOENIX-6193: ----------------------------------------- stoty commented on pull request #931: URL: https://github.com/apache/phoenix/pull/931#issuecomment-712623055 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 13m 7s | master passed | | +1 :green_heart: | compile | 1m 20s | master passed | | +1 :green_heart: | javadoc | 1m 7s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 29s | the patch passed | | +1 :green_heart: | compile | 1m 18s | the patch passed | | +1 :green_heart: | javac | 1m 18s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 1m 4s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 94m 59s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. | | | | 124m 2s | | | Reason | Tests | |-------:|:------| | Failed junit tests | phoenix.end2end.UpgradeIT | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-931/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/931 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux 31c919f98b56 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 4703e46 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-931/1/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-931/1/testReport/ | | Max. process+thread count | 7045 (vs. ulimit of 30000) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-931/1/console | | versions | git=2.7.4 maven=3.3.9 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > PHOENIX-6151 slows down shading > -------------------------------- > > Key: PHOENIX-6193 > URL: https://issues.apache.org/jira/browse/PHOENIX-6193 > Project: Phoenix > Issue Type: Bug > Components: core > Affects Versions: 5.1.0, 4.16.0 > Reporter: Istvan Toth > Assignee: Istvan Toth > Priority: Critical > Fix For: 5.1.0, 4.16.0 > > > PHOENIX-6151 increases shading time by ~400%, which is a disproportional > share of the total build time. -- This message was sent by Atlassian Jira (v8.3.4#803005)