[ https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315388#comment-17315388 ]
Hadoop QA commented on PHOENIX-6434: ------------------------------------ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 59s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} 4.x Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 25s{color} | {color:green} 4.x passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} 4.x passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 31s{color} | {color:green} 4.x passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s{color} | {color:green} 4.x passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m 17s{color} | {color:blue} phoenix-core in 4.x has 941 extant spotbugs warnings. {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 35s{color} | {color:red} phoenix-core: The patch generated 79 new + 4411 unchanged - 35 fixed = 4490 total (was 4446) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 3m 31s{color} | {color:red} phoenix-core generated 2 new + 941 unchanged - 0 fixed = 943 total (was 941) {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}204m 20s{color} | {color:red} phoenix-core in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 37s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}243m 24s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:phoenix-core | | | Possible null pointer dereference of dataColumn in org.apache.phoenix.index.IndexMaintainer$5.addDataColInfo(PTable, Expression) Dereferenced at IndexMaintainer.java:dataColumn in org.apache.phoenix.index.IndexMaintainer$5.addDataColInfo(PTable, Expression) Dereferenced at IndexMaintainer.java:[line 594] | | | Redundant nullcheck of value which is known to be null in org.apache.phoenix.schema.tuple.ValueGetterTuple.getValue(byte[], byte[]) Redundant null check at ValueGetterTuple.java:is known to be null in org.apache.phoenix.schema.tuple.ValueGetterTuple.getValue(byte[], byte[]) Redundant null check at ValueGetterTuple.java:[line 73] | | Failed junit tests | phoenix.end2end.TimezoneOffsetFunctionIT | | | phoenix.end2end.WALAnnotationIT | | | phoenix.end2end.salted.SaltedTableIT | | | phoenix.end2end.UseSchemaIT | | | phoenix.end2end.DecodeFunctionIT | | | phoenix.end2end.join.HashJoinLocalIndexIT | | | phoenix.end2end.DistinctPrefixFilterIT | | | phoenix.schema.stats.NoOpStatsCollectorIT | | | phoenix.end2end.AlterTableIT | | | phoenix.end2end.ArithmeticQueryIT | | | phoenix.end2end.InListIT | | | phoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT | | | phoenix.end2end.QueryMoreIT | | | phoenix.end2end.ReverseScanIT | | | phoenix.end2end.RenewLeaseIT | | | phoenix.end2end.ConnectionUtilIT | | | phoenix.end2end.PointInTimeScanQueryIT | | | phoenix.end2end.NumericArithmeticIT | | | phoenix.end2end.GetSetByteBitFunctionEnd2EndIT | | | phoenix.end2end.PointInTimeQueryIT | | | phoenix.end2end.DefaultColumnValueIT | | | phoenix.end2end.IndexScrutinyToolIT | | | phoenix.end2end.QueryDatabaseMetaDataIT | | | phoenix.end2end.TenantSpecificViewIndexIT | | | phoenix.end2end.SpooledTmpFileDeleteIT | | | phoenix.end2end.OrderByWithSpillingIT | | | phoenix.end2end.index.IndexMaintenanceIT | | | phoenix.end2end.QueryTimeoutIT | | | phoenix.end2end.index.LocalImmutableTxIndexIT | | | phoenix.end2end.ViewIT | | | phoenix.end2end.RowValueConstructorIT | | | phoenix.end2end.SortOrderIT | | | phoenix.schema.stats.NamespaceDisabledStatsCollectorIT | | | phoenix.end2end.CustomEntityDataIT | | | phoenix.end2end.InstrFunctionIT | | | phoenix.end2end.UpperLowerFunctionIT | | | phoenix.end2end.salted.SaltedTableUpsertSelectIT | | | phoenix.schema.stats.NamespaceEnabledStatsCollectorIT | | | phoenix.end2end.CastAndCoerceIT | | | phoenix.end2end.UngroupedIT | | | phoenix.end2end.join.WhereOptimizerForJoinFiltersIT | | | phoenix.end2end.NativeHBaseTypesIT | | | phoenix.end2end.ArrayRemoveFunctionIT | | | phoenix.end2end.DerivedTableIT | | | phoenix.end2end.OnDuplicateKeyIT | | | phoenix.end2end.index.SaltedIndexIT | | | phoenix.end2end.QueryExecWithoutSCNIT | | | phoenix.end2end.join.SortMergeJoinNoSpoolingIT | | | phoenix.end2end.RegexpSubstrFunctionIT | | | phoenix.tx.TransactionIT | | | phoenix.end2end.OrderByIT | | | phoenix.end2end.ConcurrentMutationsExtendedIT | | | phoenix.end2end.IndexExtendedIT | | | phoenix.end2end.QueryLoggerIT | | | phoenix.end2end.ExecuteStatementsIT | | | phoenix.end2end.ServerExceptionIT | | | phoenix.end2end.PartialResultServerConfigurationIT | | | phoenix.end2end.index.ImmutableIndexIT | | | phoenix.end2end.MapReduceIT | | | phoenix.end2end.index.MutableIndexFailureIT | | | phoenix.end2end.IndexScrutinyToolForTenantIT | | | phoenix.end2end.NthValueFunctionIT | | | phoenix.end2end.DateTimeIT | | | phoenix.end2end.DateArithmeticIT | | | phoenix.end2end.SignFunctionEnd2EndIT | | | phoenix.end2end.ArrayFillFunctionIT | | | phoenix.end2end.BackwardCompatibilityForSplittableSyscatIT | | | phoenix.end2end.DropTableIT | | | phoenix.end2end.AlterTableWithViewsIT | | | phoenix.end2end.PhoenixTTLToolIT | | | phoenix.end2end.BinaryRowKeyIT | | | phoenix.end2end.CountDistinctApproximateHyperLogLogIT | | | phoenix.end2end.SerialIteratorsIT | | | phoenix.end2end.ArrayPrependFunctionIT | | | phoenix.monitoring.PhoenixMetricsIT | | | phoenix.end2end.RoundFloorCeilFuncIT | | | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | | phoenix.end2end.AppendOnlySchemaIT | | | phoenix.end2end.UnionAllIT | | | phoenix.end2end.DescOrderKeysIT | | | phoenix.end2end.Array1IT | | | phoenix.end2end.index.DropColumnIT | | | phoenix.end2end.join.SubqueryIT | | | phoenix.end2end.index.GlobalIndexOptimizationIT | | | phoenix.end2end.CoalesceFunctionIT | | | phoenix.end2end.AggregateQueryIT | | | phoenix.end2end.index.MutableIndexFailureWithNamespaceIT | | | phoenix.end2end.TableSnapshotReadsMapReduceIT | | | phoenix.end2end.ToCharFunctionIT | | | phoenix.end2end.CsvBulkLoadToolIT | | | phoenix.end2end.EmptyColumnIT | | | phoenix.end2end.PermissionNSEnabledIT | | | phoenix.end2end.MultiCfQueryExecIT | | | phoenix.end2end.ToNumberFunctionIT | | | phoenix.end2end.TransactionalViewIT | | | phoenix.end2end.index.ViewIndexIT | | | phoenix.rpc.PhoenixServerRpcIT | | | phoenix.end2end.index.GlobalImmutableNonTxIndexIT | | | phoenix.monitoring.PhoenixLoggingMetricsIT | | | phoenix.end2end.AbsFunctionEnd2EndIT | | | phoenix.end2end.join.HashJoinGlobalIndexIT | | | phoenix.end2end.StringIT | | | phoenix.end2end.AlterSessionIT | | | phoenix.end2end.UpsertSelectAutoCommitIT | | | phoenix.end2end.CSVCommonsLoaderIT | | | phoenix.end2end.index.GlobalMutableNonTxIndexWithLazyPostBatchWriteIT | | | phoenix.end2end.SequenceIT | | | phoenix.end2end.UpsertBigValuesIT | | | phoenix.end2end.TenantSpecificTablesDDLIT | | | phoenix.end2end.RowTimestampIT | | | phoenix.end2end.SetPropertyOnNonEncodedTableIT | | | phoenix.tx.FlappingTransactionIT | | | phoenix.end2end.MutationStateIT | | | phoenix.end2end.NotQueryWithGlobalImmutableIndexesIT | | | phoenix.end2end.join.HashJoinNoIndexIT | | | phoenix.end2end.NotQueryWithLocalImmutableIndexesIT | | | phoenix.end2end.UpsertSelectIT | | | phoenix.end2end.PermissionsCacheIT | | | phoenix.end2end.TenantSpecificTablesDMLIT | | | phoenix.end2end.ToDateFunctionIT | | | phoenix.end2end.join.SortMergeJoinLocalIndexIT | | | phoenix.end2end.join.SubqueryUsingSortMergeJoinIT | | | phoenix.end2end.PartialScannerResultsDisabledIT | | | phoenix.end2end.SortMergeJoinMoreIT | | | phoenix.end2end.ImmutableTableIT | | | phoenix.end2end.index.LocalImmutableNonTxIndexIT | | | phoenix.end2end.IsNullIT | | | phoenix.end2end.ExtendedQueryExecIT | | | phoenix.end2end.CursorWithRowValueConstructorIT | | | phoenix.end2end.index.GlobalMutableNonTxIndexIT | | | phoenix.end2end.NamespaceSchemaMappingIT | | | phoenix.query.MaxConcurrentConnectionsIT | | | phoenix.end2end.Array3IT | | | phoenix.end2end.ViewMetadataIT | | | phoenix.end2end.StatementHintsIT | | | phoenix.end2end.index.PartialIndexRebuilderIT | | | phoenix.iterate.RoundRobinResultIteratorWithStatsIT | | | phoenix.end2end.ExpFunctionEnd2EndIT | | | phoenix.end2end.PrimitiveTypeIT | | | phoenix.end2end.index.LocalMutableTxIndexIT | | | phoenix.end2end.ViewTTLIT | | | phoenix.end2end.ArrayToStringFunctionIT | | | phoenix.end2end.AggregateIT | | | phoenix.end2end.EncodeFunctionIT | | | phoenix.end2end.join.SortMergeJoinGlobalIndexIT | | | phoenix.end2end.IndexRepairRegionScannerIT | | | phoenix.end2end.index.AlterIndexIT | | | phoenix.end2end.index.IndexUsageIT | | | phoenix.end2end.DynamicColumnIT | | | phoenix.end2end.SequenceBulkAllocationIT | | | phoenix.end2end.LikeExpressionIT | | | phoenix.tx.TxCheckpointIT | | | phoenix.end2end.GroupByIT | | | phoenix.end2end.join.SortMergeJoinNoIndexIT | | | phoenix.end2end.InQueryIT | | | phoenix.end2end.join.HashJoinCacheIT | | | phoenix.end2end.join.HashJoinMoreIT | | | phoenix.end2end.EvaluationOfORIT | | | phoenix.end2end.DisableLocalIndexIT | | | phoenix.end2end.VariableLengthPKIT | | | phoenix.end2end.KeyOnlyIT | | | phoenix.end2end.RTrimFunctionIT | | | phoenix.end2end.DeleteIT | | | phoenix.end2end.SystemTablesCreationOnConnectionIT | | | phoenix.end2end.CaseStatementIT | | | phoenix.end2end.DistinctCountIT | | | phoenix.end2end.ExplainPlanWithStatsEnabledIT | | | phoenix.end2end.SkipScanQueryIT | | | phoenix.end2end.CreateTableIT | | | phoenix.end2end.RegexpSplitFunctionIT | | | phoenix.end2end.StringToArrayFunctionIT | | | phoenix.schema.stats.TxStatsCollectorIT | | | phoenix.end2end.ConcurrentMutationsIT | | | phoenix.end2end.UserDefinedFunctionsIT | | | phoenix.end2end.ParallelIteratorsIT | | | phoenix.end2end.index.LocalMutableNonTxIndexIT | | | phoenix.end2end.ArrayConcatFunctionIT | | | phoenix.end2end.ProductMetricsIT | | | phoenix.tx.ParameterizedTransactionIT | | | phoenix.end2end.RangeScanIT | | | phoenix.end2end.OrderByWithServerClientSpoolingDisabledIT | | | phoenix.end2end.index.IndexAsyncThresholdIT | | | phoenix.end2end.UpgradeNamespaceIT | | | phoenix.end2end.QueryWithOffsetIT | | | phoenix.util.IndexScrutinyIT | | | phoenix.end2end.ReverseFunctionIT | | | phoenix.end2end.QueryWithLimitIT | | | phoenix.end2end.PercentileIT | | | phoenix.end2end.QueryIT | | | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT | | | phoenix.end2end.IndexToolIT | | | phoenix.schema.stats.NonTxStatsCollectorIT | | | phoenix.end2end.UpdateCacheAcrossDifferentClientsIT | | | phoenix.end2end.index.GlobalMutableTxIndexIT | | | phoenix.end2end.RegexpReplaceFunctionIT | | | phoenix.end2end.StatsEnabledSplitSystemCatalogIT | | | phoenix.end2end.ProjectArrayElemAfterHashJoinIT | | | phoenix.end2end.index.SingleCellIndexIT | | | phoenix.end2end.ColumnProjectionOptimizationIT | | | phoenix.end2end.PhoenixRowTimestampFunctionIT | | | phoenix.end2end.ContextClassloaderIT | | | phoenix.end2end.CbrtFunctionEnd2EndIT | | | phoenix.end2end.IndexToolForNonTxGlobalIndexIT | | | phoenix.end2end.index.MutableIndexIT | | | phoenix.end2end.ArrayAppendFunctionIT | | | phoenix.end2end.IntArithmeticIT | | | phoenix.end2end.NullIT | | | phoenix.end2end.PermissionNSDisabledIT | | | phoenix.end2end.index.LocalIndexIT | | | phoenix.end2end.Array2IT | | | phoenix.end2end.index.IndexMetadataIT | | | phoenix.end2end.index.GlobalImmutableTxIndexIT | | | phoenix.end2end.RowKeyBytesStringFunctionIT | | | phoenix.end2end.MD5FunctionIT | | | phoenix.end2end.join.HashJoinPersistentCacheIT | | | phoenix.end2end.DropSchemaIT | | | phoenix.execute.PartialCommitIT | | | phoenix.end2end.SqrtFunctionEnd2EndIT | | | phoenix.end2end.UpsertValuesIT | | | phoenix.end2end.ModulusExpressionIT | | | phoenix.end2end.RowValueConstructorOffsetIT | | | phoenix.end2end.SetPropertyOnEncodedTableIT | | | phoenix.end2end.QueryWithTableSampleIT | | | phoenix.end2end.BackwardCompatibilityIT | | | phoenix.end2end.SkipScanAfterManualSplitIT | | | phoenix.iterate.RoundRobinResultIteratorIT | | | phoenix.end2end.StoreNullsIT | | | phoenix.end2end.PhoenixRuntimeIT | \\ \\ || Subsystem || Report/Notes || | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/382/artifact/patchprocess/Dockerfile | | JIRA Issue | PHOENIX-6434 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13023418/PHOENIX-6434.4.x.001.patch | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux e5cbcc9c91d7 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 5c57004 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/382/artifact/patchprocess/diff-checkstyle-phoenix-core.txt | | whitespace | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/382/artifact/patchprocess/whitespace-tabs.txt | | spotbugs | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/382/artifact/patchprocess/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/382/artifact/patchprocess/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/382/testReport/ | | Max. process+thread count | 4866 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/382/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. > Secondary Indexes on PHOENIX_ROW_TIMESTAMP() > -------------------------------------------- > > Key: PHOENIX-6434 > URL: https://issues.apache.org/jira/browse/PHOENIX-6434 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 5.1.0, 4.16.0 > Reporter: Kadir Ozdemir > Priority: Major > Attachments: PHOENIX-6434.4.x.001.patch > > > PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the > last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a > projection column and referred in a WHERE clause. It is desirable to have > indexes on row timestamps. This will result in fast time range queries. -- This message was sent by Atlassian Jira (v8.3.4#803005)