[ https://issues.apache.org/jira/browse/PHOENIX-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319765#comment-17319765 ]
ASF GitHub Bot commented on PHOENIX-6434: ----------------------------------------- stoty commented on pull request #1194: URL: https://github.com/apache/phoenix/pull/1194#issuecomment-818289376 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 6m 47s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 13s | 4.x passed | | +1 :green_heart: | compile | 1m 34s | 4.x passed | | +1 :green_heart: | checkstyle | 1m 50s | 4.x passed | | +1 :green_heart: | javadoc | 0m 55s | 4.x passed | | +0 :ok: | spotbugs | 3m 51s | phoenix-core in 4.x has 945 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 3s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | -1 :x: | checkstyle | 1m 53s | phoenix-core: The patch generated 86 new + 4405 unchanged - 39 fixed = 4491 total (was 4444) | | -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. | | +1 :green_heart: | javadoc | 0m 56s | the patch passed | | -1 :x: | spotbugs | 4m 5s | phoenix-core generated 2 new + 945 unchanged - 0 fixed = 947 total (was 945) | ||| _ Other Tests _ | | -1 :x: | unit | 264m 29s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. | | | | 314m 29s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | Possible null pointer dereference of dataColumn in org.apache.phoenix.index.IndexMaintainer$5.addDataColInfo(PTable, Expression) Dereferenced at IndexMaintainer.java:dataColumn in org.apache.phoenix.index.IndexMaintainer$5.addDataColInfo(PTable, Expression) Dereferenced at IndexMaintainer.java:[line 594] | | | Redundant nullcheck of value which is known to be null in org.apache.phoenix.schema.tuple.ValueGetterTuple.getValue(byte[], byte[]) Redundant null check at ValueGetterTuple.java:is known to be null in org.apache.phoenix.schema.tuple.ValueGetterTuple.getValue(byte[], byte[]) Redundant null check at ValueGetterTuple.java:[line 73] | | Failed junit tests | phoenix.tx.ParameterizedTransactionIT | | | phoenix.end2end.CsvBulkLoadToolIT | | | phoenix.util.IndexScrutinyIT | | | phoenix.tx.TransactionIT | | | phoenix.end2end.index.PartialIndexRebuilderIT | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1194 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 946865c23673 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 33f2463 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/whitespace-tabs.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/testReport/ | | Max. process+thread count | 4765 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1194/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Secondary Indexes on PHOENIX_ROW_TIMESTAMP() > -------------------------------------------- > > Key: PHOENIX-6434 > URL: https://issues.apache.org/jira/browse/PHOENIX-6434 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 5.1.0, 4.16.0 > Reporter: Kadir Ozdemir > Priority: Major > Attachments: PHOENIX-6434.4.x.001.patch, PHOENIX-6434.4.x.002.patch, > PHOENIX-6434.4.x.003.patch > > > PHOENIX-5629 introduced the function PHOENIX_ROW_TIMESTAMP() that returns the > last modified time of a row. PHOENIX_ROW_TIMESTAMP() can be used as a > projection column and referred in a WHERE clause. It is desirable to have > indexes on row timestamps. This will result in fast time range queries. -- This message was sent by Atlassian Jira (v8.3.4#803005)