[ 
https://issues.apache.org/jira/browse/PHOENIX-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17393853#comment-17393853
 ] 

ASF GitHub Bot commented on PHOENIX-5215:
-----------------------------------------

stoty commented on pull request #1282:
URL: https://github.com/apache/phoenix/pull/1282#issuecomment-893213028


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   5m 30s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
1 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   4m 59s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  19m 38s |  master passed  |
   | +0 |  hbaserecompile  |  31m 43s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 48s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 47s |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 25s |  master passed  |
   | +0 :ok: |  spotbugs  |   5m  2s |  root in master has 1032 extant spotbugs 
warnings.  |
   | +0 :ok: |  spotbugs  |   3m 17s |  phoenix-core in master has 973 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m 18s |  root in the patch failed.  |
   | +0 |  hbaserecompile  |   8m 39s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 49s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 49s |  the patch passed  |
   | -1 :x: |  checkstyle  |   1m 49s |  root: The patch generated 106 new + 
2243 unchanged - 140 fixed = 2349 total (was 2383)  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch 1 line(s) with tabs.  |
   | +1 :green_heart: |  xml  |   0m  5s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   2m 18s |  the patch passed  |
   | -1 :x: |  spotbugs  |   3m 36s |  phoenix-core generated 5 new + 968 
unchanged - 5 fixed = 973 total (was 973)  |
   | -1 :x: |  spotbugs  |   5m 14s |  root generated 5 new + 1027 unchanged - 
5 fixed = 1032 total (was 1032)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   2m  0s |  root in the patch failed.  |
   | -1 :x: |  asflicense  |   0m 49s |  The patch generated 614 ASF License 
warnings.  |
   |  |   |  80m 27s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  Dead store to connSpan in 
org.apache.phoenix.compile.TraceQueryPlan$TraceQueryResultIterator.next()  At 
TraceQueryPlan.java:org.apache.phoenix.compile.TraceQueryPlan$TraceQueryResultIterator.next()
  At TraceQueryPlan.java:[line 262] |
   |  |  Exception is caught when Exception is not thrown in 
org.apache.phoenix.execute.MutationState.sendMutations(Iterator, Span, 
ImmutableBytesWritable, boolean)  At MutationState.java:is not thrown in 
org.apache.phoenix.execute.MutationState.sendMutations(Iterator, Span, 
ImmutableBytesWritable, boolean)  At MutationState.java:[line 1403] |
   |  |  Invocation of toString on 
org.apache.hadoop.hbase.util.Bytes.toBytes(int) in 
org.apache.phoenix.hbase.index.Indexer.preBatchMutateWithExceptions(ObserverContext,
 MiniBatchOperationInProgress)  At Indexer.java:in 
org.apache.phoenix.hbase.index.Indexer.preBatchMutateWithExceptions(ObserverContext,
 MiniBatchOperationInProgress)  At Indexer.java:[line 510] |
   |  |  Dead store to stmt in 
org.apache.phoenix.trace.TraceWriter$FlushMetrics.addToBatch(Span)  At 
TraceWriter.java:org.apache.phoenix.trace.TraceWriter$FlushMetrics.addToBatch(Span)
  At TraceWriter.java:[line 147] |
   |  |  Unread field:TraceWriter.java:[line 118] |
   | FindBugs | module:root |
   |  |  Dead store to connSpan in 
org.apache.phoenix.compile.TraceQueryPlan$TraceQueryResultIterator.next()  At 
TraceQueryPlan.java:org.apache.phoenix.compile.TraceQueryPlan$TraceQueryResultIterator.next()
  At TraceQueryPlan.java:[line 262] |
   |  |  Exception is caught when Exception is not thrown in 
org.apache.phoenix.execute.MutationState.sendMutations(Iterator, Span, 
ImmutableBytesWritable, boolean)  At MutationState.java:is not thrown in 
org.apache.phoenix.execute.MutationState.sendMutations(Iterator, Span, 
ImmutableBytesWritable, boolean)  At MutationState.java:[line 1403] |
   |  |  Invocation of toString on 
org.apache.hadoop.hbase.util.Bytes.toBytes(int) in 
org.apache.phoenix.hbase.index.Indexer.preBatchMutateWithExceptions(ObserverContext,
 MiniBatchOperationInProgress)  At Indexer.java:in 
org.apache.phoenix.hbase.index.Indexer.preBatchMutateWithExceptions(ObserverContext,
 MiniBatchOperationInProgress)  At Indexer.java:[line 510] |
   |  |  Dead store to stmt in 
org.apache.phoenix.trace.TraceWriter$FlushMetrics.addToBatch(Span)  At 
TraceWriter.java:org.apache.phoenix.trace.TraceWriter$FlushMetrics.addToBatch(Span)
  At TraceWriter.java:[line 147] |
   |  |  Unread field:TraceWriter.java:[line 118] |
   | Failed junit tests | phoenix.schema.MetaDataClientTest |
   |   | phoenix.compile.CursorCompilerTest |
   |   | phoenix.compile.HavingCompilerTest |
   |   | phoenix.compile.CreateTableCompilerTest |
   |   | phoenix.compile.TenantSpecificViewIndexCompileTest |
   |   | phoenix.index.PrepareIndexMutationsForRebuildTest |
   |   | phoenix.util.csv.CsvUpsertExecutorTest |
   |   | phoenix.index.IndexMaintainerTest |
   |   | phoenix.execute.LiteralResultIteratorPlanTest |
   |   | phoenix.compile.PostIndexDDLCompilerTest |
   |   | phoenix.iterate.RowKeyOrderedAggregateResultIteratorTest |
   |   | phoenix.index.IndexScrutinyMapperTest |
   |   | phoenix.util.PhoenixRuntimeTest |
   |   | phoenix.execute.MutationStateTest |
   |   | phoenix.jdbc.PhoenixDriverTest |
   |   | phoenix.util.ScanUtilTest |
   |   | phoenix.iterate.AggregateResultScannerTest |
   |   | phoenix.query.KeyRangeClipTest |
   |   | phoenix.compile.QueryOptimizerTest |
   |   | phoenix.compile.QueryCompilerTest |
   |   | phoenix.util.json.JsonUpsertExecutorTest |
   |   | phoenix.compile.LimitCompilerTest |
   |   | phoenix.compile.StatementHintsCompilationTest |
   |   | phoenix.index.IndexUpgradeToolTest |
   |   | phoenix.compile.ViewCompilerTest |
   |   | phoenix.compile.WhereCompilerTest |
   |   | phoenix.compile.QueryMetaDataTest |
   |   | phoenix.mapreduce.util.IndexColumnNamesTest |
   |   | phoenix.jdbc.PhoenixResultSetMetadataTest |
   |   | phoenix.hbase.index.covered.NonTxIndexBuilderTest |
   |   | phoenix.mapreduce.util.PhoenixConfigurationUtilTest |
   |   | phoenix.query.ConnectionlessTest |
   |   | phoenix.index.VerifySingleIndexRowTest |
   |   | phoenix.mapreduce.index.IndexScrutinyTableOutputTest |
   |   | phoenix.query.QueryPlanTest |
   |   | phoenix.expression.RoundFloorCeilExpressionsTest |
   |   | phoenix.expression.NullValueTest |
   |   | phoenix.jdbc.PhoenixPreparedStatementTest |
   |   | phoenix.compile.WhereOptimizerTest |
   |   | phoenix.filter.SkipScanBigFilterTest |
   |   | phoenix.compile.SelectStatementRewriterTest |
   |   | phoenix.util.PhoenixEncodeDecodeTest |
   |   | phoenix.schema.MutationTest |
   |   | phoenix.query.ParallelIteratorsSplitTest |
   |   | phoenix.compile.JoinQueryCompilerTest |
   |   | phoenix.schema.RowKeyValueAccessorTest |
   |   | phoenix.query.OrderByTest |
   |   | phoenix.schema.RowKeySchemaTest |
   |   | phoenix.execute.UnnestArrayPlanTest |
   |   | phoenix.query.ExplainPlanTextTest |
   |   | phoenix.query.ScannerLeaseRenewalTest |
   |   | phoenix.query.PropertyPolicyProviderTest |
   |   | phoenix.util.csv.StringToArrayConverterTest |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1282 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile 
spotbugs hbaserebuild hbaseanti checkstyle |
   | uname | Linux daca070caeae 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 
06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 025a4af |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/artifact/yetus-general-check/output/whitespace-tabs.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/artifact/yetus-general-check/output/new-spotbugs-root.html
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/testReport/
 |
   | asflicense | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 493 (vs. ulimit of 30000) |
   | modules | C: phoenix-core phoenix-assembly . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove and replace HTrace
> -------------------------
>
>                 Key: PHOENIX-5215
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5215
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Andrew Kyle Purtell
>            Assignee: Kiran Kumar Maturi
>            Priority: Major
>
> HTrace is dead.
> Hadoop is discussing a replacement of HTrace with OpenTracing, see 
> HADOOP-15566 
> HBase is having the same discussion on HBASE-22120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to