[ 
https://issues.apache.org/jira/browse/PHOENIX-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399595#comment-17399595
 ] 

ASF GitHub Bot commented on PHOENIX-5215:
-----------------------------------------

stoty commented on pull request #1282:
URL: https://github.com/apache/phoenix/pull/1282#issuecomment-899317809


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   5m 31s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
1 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   5m 21s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  16m 37s |  master passed  |
   | +0 |  hbaserecompile  |  28m 21s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 39s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m  4s |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 20s |  master passed  |
   | +0 :ok: |  spotbugs  |   4m 32s |  root in master has 1032 extant spotbugs 
warnings.  |
   | +0 :ok: |  spotbugs  |   3m  1s |  phoenix-core in master has 973 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  13m 29s |  the patch passed  |
   | +0 |  hbaserecompile  |  20m  4s |  HBase recompiled.  |
   | +1 :green_heart: |  compile  |   1m 38s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 38s |  the patch passed  |
   | -1 :x: |  checkstyle  |   2m  2s |  root: The patch generated 138 new + 
2287 unchanged - 170 fixed = 2425 total (was 2457)  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch 1 line(s) with tabs.  |
   | +1 :green_heart: |  xml  |   0m  4s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   2m 22s |  the patch passed  |
   | -1 :x: |  spotbugs  |   3m 20s |  phoenix-core generated 4 new + 968 
unchanged - 5 fixed = 972 total (was 973)  |
   | -1 :x: |  spotbugs  |   4m 50s |  root generated 4 new + 1027 unchanged - 
5 fixed = 1031 total (was 1032)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 115m 56s |  root in the patch failed.  |
   | -1 :x: |  asflicense  |   2m 27s |  The patch generated 614 ASF License 
warnings.  |
   |  |   | 204m 20s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  Dead store to connSpan in 
org.apache.phoenix.compile.TraceQueryPlan$TraceQueryResultIterator.next()  At 
TraceQueryPlan.java:org.apache.phoenix.compile.TraceQueryPlan$TraceQueryResultIterator.next()
  At TraceQueryPlan.java:[line 262] |
   |  |  Invocation of toString on 
org.apache.hadoop.hbase.util.Bytes.toBytes(int) in 
org.apache.phoenix.hbase.index.Indexer.preBatchMutateWithExceptions(ObserverContext,
 MiniBatchOperationInProgress)  At Indexer.java:in 
org.apache.phoenix.hbase.index.Indexer.preBatchMutateWithExceptions(ObserverContext,
 MiniBatchOperationInProgress)  At Indexer.java:[line 510] |
   |  |  Dead store to stmt in 
org.apache.phoenix.trace.TraceWriter$FlushMetrics.addToBatch(Span)  At 
TraceWriter.java:org.apache.phoenix.trace.TraceWriter$FlushMetrics.addToBatch(Span)
  At TraceWriter.java:[line 147] |
   |  |  Unread field:TraceWriter.java:[line 118] |
   | FindBugs | module:root |
   |  |  Dead store to connSpan in 
org.apache.phoenix.compile.TraceQueryPlan$TraceQueryResultIterator.next()  At 
TraceQueryPlan.java:org.apache.phoenix.compile.TraceQueryPlan$TraceQueryResultIterator.next()
  At TraceQueryPlan.java:[line 262] |
   |  |  Invocation of toString on 
org.apache.hadoop.hbase.util.Bytes.toBytes(int) in 
org.apache.phoenix.hbase.index.Indexer.preBatchMutateWithExceptions(ObserverContext,
 MiniBatchOperationInProgress)  At Indexer.java:in 
org.apache.phoenix.hbase.index.Indexer.preBatchMutateWithExceptions(ObserverContext,
 MiniBatchOperationInProgress)  At Indexer.java:[line 510] |
   |  |  Dead store to stmt in 
org.apache.phoenix.trace.TraceWriter$FlushMetrics.addToBatch(Span)  At 
TraceWriter.java:org.apache.phoenix.trace.TraceWriter$FlushMetrics.addToBatch(Span)
  At TraceWriter.java:[line 147] |
   |  |  Unread field:TraceWriter.java:[line 118] |
   | Failed junit tests | phoenix.trace.PhoenixTableMetricsWriterIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/4/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/1282 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile 
spotbugs hbaserebuild hbaseanti checkstyle |
   | uname | Linux de1af7ff6e0d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / c4d297d |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/4/artifact/yetus-general-check/output/whitespace-tabs.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/4/artifact/yetus-general-check/output/new-spotbugs-root.html
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/4/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/4/testReport/
 |
   | asflicense | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 16258 (vs. ulimit of 30000) |
   | modules | C: phoenix-core phoenix-assembly . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1282/4/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Remove and replace HTrace
> -------------------------
>
>                 Key: PHOENIX-5215
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5215
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Andrew Kyle Purtell
>            Assignee: Kiran Kumar Maturi
>            Priority: Major
>
> HTrace is dead.
> Hadoop is discussing a replacement of HTrace with OpenTracing, see 
> HADOOP-15566 
> HBase is having the same discussion on HBASE-22120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to