dbwong commented on pull request #1289: URL: https://github.com/apache/phoenix/pull/1289#issuecomment-904353416
Mmy comment on robustness was not pointing toward jodatime or jsr being more robust than another but rather in consideration of other datetime libraries from a future feature point of view as I know many SQL users have wanted in the past from my experience implementing many date time functions in other large databases. Apologies if I missed any library discussion on the JIRA but I mostly saw a great job covering the underlying currently used libraries and the time representation we were using. Maybe these were library discussions, thus class names, when I was assuming you were only discussing the calendar system. Note that joda time also wants people to migrate to js-310 and the implementer supports a maven backwards compatibility package for jdk7 though I haven't done full investigation on the performance. One last question, can customer data could be "corrupt" based on how the data get entered into the table if from SQL constant vs function based path? Would this change break customer data if one path was used and not another? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
