stoty commented on pull request #1289: URL: https://github.com/apache/phoenix/pull/1289#issuecomment-904364537
@dbwong I absolutely support migrating to JSR-310, as soon 4.x is out of the picture. I got the impression that Java 7 JSR310 library is not really a production quality thing, but I may be wrong. The JSR310 vs Java7 discussion happened in another JIRA earlier, not this one. Yes, existing time data will be impacted. AFACT we only use JodaTime (with ISO chronology) in the write path, and we always read with the java.util.Date classes, and the current approach uses the java.util.Date compatible chronology for both read and write. However, some date/time functions do use Joda time internally, so the function output may be affected by the change, even if reading the values directly is not. I wouldn't worry about it too mach, as only pre-gregorian dates are affected, and the current mess makes using those impractical anyway. One issue with the approach in this patch is that we will need to re-implement GJChronology for the JSR310 migration, as it doesn't have that chronology by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
