mnpoonia commented on PR #1541: URL: https://github.com/apache/phoenix/pull/1541#issuecomment-1357819106
>I think we need to use DELETE_BATCH_FAILED_SIZE, right? That was the reason this JIRA was created in the first place. Am I understanding something wrong? Table being transactional doesn't have to do anything with how many deletes failed in that batch. Both are orthogonal. We tried to delete 4 rows and that failed. So the metric should reflect how many rows we tried to delete and failed. @shahrs87 You are right. table being transactional or not doesn't change the value of DELETE_BATCH_FAILED_SIZE. But when it comes to mutation while we are in transactional table we consider a set of command as single mutation and that can be only reason i consider that MUTATION_BATCH_FAILED_SIZE differs. So in that sense it looks fine. What do you think we are missing here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
