mnpoonia commented on PR #1541: URL: https://github.com/apache/phoenix/pull/1541#issuecomment-1362372145
@shahrs87 I think now i understand what you are retrying to say. Now that i look at the metric name again i think we should not consider anything special about this metric if table is tx or non tx. If we ever need special cases we can create special metric with some prefix or suffix indicating it is for tx tables. Also if we look at the code again ideally a delete statement should not be part of a batch else(we can talk about it some other day). The problem with deletes combing with upsert of having multiple delete in same batch is as below - If we have a batch with two delete statements and if one statement failed we will get a number saying that x num of deletes failed. But we don't know if it was first delete stmt or second or both failed. Maybe there is a smart way to figure out which i will look in code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
