[ 
https://issues.apache.org/jira/browse/PHOENIX-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788188#comment-17788188
 ] 

ASF GitHub Bot commented on PHOENIX-7073:
-----------------------------------------

tkhurana commented on code in PR #1712:
URL: https://github.com/apache/phoenix/pull/1712#discussion_r1399875119


##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java:
##########
@@ -713,9 +782,10 @@ protected ColumnRef resolveColumn(ColumnParseNode node) 
throws SQLException {
         @Override
         public Expression visit(ColumnParseNode node) throws SQLException {
             Expression expression = super.visit(node);
-            if (expression.getDataType().isArrayType()) {
-                Integer count = arrayExpressionCounts.get(expression);
-                arrayExpressionCounts.put(expression, count != null ? (count + 
1) : 1);
+            if (expression.getDataType().isArrayType() || 
expression.getDataType()

Review Comment:
   maybe add a helper function `parseOnServer(expression)`





> Parse JSON columns on the server side
> -------------------------------------
>
>                 Key: PHOENIX-7073
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7073
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Ranganath Govardhanagiri
>            Assignee: Ranganath Govardhanagiri
>            Priority: Major
>
> One of the optimizations mentioned in the Design spec is to _"pass the json 
> path to server side as part of the select and do the parsing on the server 
> side and then return the result to the client."_
> This is the task to track that change



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to