[
https://issues.apache.org/jira/browse/PHOENIX-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788245#comment-17788245
]
ASF GitHub Bot commented on PHOENIX-7073:
-----------------------------------------
ranganathg commented on code in PR #1712:
URL: https://github.com/apache/phoenix/pull/1712#discussion_r1400011421
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java:
##########
@@ -677,21 +742,25 @@ private static class SelectClauseVisitor extends
ExpressionCompiler {
*/
private boolean isCaseSensitive;
private int elementCount;
- private List<KeyValueColumnExpression> arrayKVRefs;
- private List<Expression> arrayKVFuncs;
- private List<Expression> arrayOldFuncs;
- private List<ProjectedColumnExpression> arrayProjectedColumnRefs;
- private Map<Expression, Integer> arrayExpressionCounts;
- private SelectStatement statement;
-
- private SelectClauseVisitor(StatementContext context, GroupBy groupBy,
- List<KeyValueColumnExpression> arrayKVRefs, List<Expression>
arrayKVFuncs, Map<Expression, Integer> arrayExpressionCounts,
List<ProjectedColumnExpression> arrayProjectedColumnRefs, List<Expression>
arrayOldFuncs, SelectStatement statement) {
+ private List<KeyValueColumnExpression> serverParsedKVRefs;
+ private List<Expression> serverParsedKVFuncs;
+ private List<Expression> serverParsedOldFuncs;
+ private List<ProjectedColumnExpression>
serverParsedProjectedColumnRefs;
+ private Map<Expression, Integer> serverParsedExpressionCounts;
+ private SelectStatement statement;
+
+ private SelectClauseVisitor(StatementContext context, GroupBy groupBy,
+ List<KeyValueColumnExpression> serverParsedKVRefs,
+ List<Expression> serverParsedKVFuncs,
+ Map<Expression, Integer> serverParsedExpressionCounts,
+ List<ProjectedColumnExpression>
serverParsedProjectedColumnRefs,
+ List<Expression> serverParsedOldFuncs, SelectStatement
statement) {
super(context, groupBy);
- this.arrayKVRefs = arrayKVRefs;
- this.arrayKVFuncs = arrayKVFuncs;
- this.arrayOldFuncs = arrayOldFuncs;
- this.arrayExpressionCounts = arrayExpressionCounts;
- this.arrayProjectedColumnRefs = arrayProjectedColumnRefs;
+ this.serverParsedKVRefs = serverParsedKVRefs;
Review Comment:
These are based on the comments in a JIRA where we convert the projected
columns to KeyValueExpressions. I will probably provide a reference to that
JIRA so that the context would be clear.
> Parse JSON columns on the server side
> -------------------------------------
>
> Key: PHOENIX-7073
> URL: https://issues.apache.org/jira/browse/PHOENIX-7073
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Ranganath Govardhanagiri
> Assignee: Ranganath Govardhanagiri
> Priority: Major
>
> One of the optimizations mentioned in the Design spec is to _"pass the json
> path to server side as part of the select and do the parsing on the server
> side and then return the result to the client."_
> This is the task to track that change
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
