[
https://issues.apache.org/jira/browse/PHOENIX-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788192#comment-17788192
]
ASF GitHub Bot commented on PHOENIX-7073:
-----------------------------------------
tkhurana commented on code in PR #1712:
URL: https://github.com/apache/phoenix/pull/1712#discussion_r1399888342
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java:
##########
@@ -641,19 +702,23 @@ public <T> T accept(ExpressionVisitor<T> visitor) {
return null;
}
}
- private static void
serailizeArrayIndexInformationAndSetInScan(StatementContext context,
List<Expression> arrayKVFuncs,
- List<KeyValueColumnExpression> arrayKVRefs) {
+
+ private static void serializeServerParsedExpressionInformationAndSetInScan(
+ StatementContext context, String serverParsedExpressionAttribute,
+ List<Expression> serverParsedKVFuncs,
+ List<KeyValueColumnExpression> serverParsedKVRefs) {
ByteArrayOutputStream stream = new ByteArrayOutputStream();
try {
DataOutputStream output = new DataOutputStream(stream);
- // Write the arrayKVRef size followed by the keyvalues that needs
to be of type arrayindex function
- WritableUtils.writeVInt(output, arrayKVRefs.size());
- for (Expression expression : arrayKVRefs) {
+ // Write the arrayKVRef size followed by the keyvalues that needs
to be of
+ // type arrayindex+json function
Review Comment:
Isn't this comment should be arrayIndex **OR** json. We serialize all of
these types independently
> Parse JSON columns on the server side
> -------------------------------------
>
> Key: PHOENIX-7073
> URL: https://issues.apache.org/jira/browse/PHOENIX-7073
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Ranganath Govardhanagiri
> Assignee: Ranganath Govardhanagiri
> Priority: Major
>
> One of the optimizations mentioned in the Design spec is to _"pass the json
> path to server side as part of the select and do the parsing on the server
> side and then return the result to the client."_
> This is the task to track that change
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
