stoty commented on code in PR #1745:
URL: https://github.com/apache/phoenix/pull/1745#discussion_r1425740304


##########
pom.xml:
##########
@@ -1887,6 +1888,17 @@
           @{jacocoArgLine}</argLine>
       </properties>
     </profile>
+    <profile>

Review Comment:
   Do we need a profile for this ?
   Specifying -DshadeSources=false would have the same effect.
   
   But if you  prefer this way, it's fine, too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to