stoty commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1873770999
I have tested this now, but the shading time difference is seems to be minimal. On my machine it takes ~3:20 with the shaded sources, and ~3:05 without them. I don't have a problem with committing this, but I wander what kind of improvement do you see with the patch, @NihalJain ? Also I have just merged phoenix-client-lite, you may want to update the patch to add same change there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
