NihalJain commented on code in PR #1745:
URL: https://github.com/apache/phoenix/pull/1745#discussion_r1425835448
##########
pom.xml:
##########
@@ -1887,6 +1888,17 @@
@{jacocoArgLine}</argLine>
</properties>
</profile>
+ <profile>
Review Comment:
Yes actually just having a profile for a variable which can be passed from
outside does not make sense. But I was thinking if we also add
`maven.source.skip` to be true `here` and rename this profile to
`skipSourceProcessing` or something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
