palashc commented on code in PR #1807:
URL: https://github.com/apache/phoenix/pull/1807#discussion_r1473629411
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ValidateLastDDLTimestampUtil.java:
##########
@@ -143,14 +143,17 @@ public static void validateLastDDLTimestamp(
for (TableRef tableRef : tableRefs) {
- //when querying an index, we need to validate its parent table
- //in case the index was dropped
- if (PTableType.INDEX.equals(tableRef.getTable().getType())) {
+ // validate all ancestors of this PTable if any
+ // index -> base table
+ // view -> parent view and its ancestors
+ // view index -> view and its ancestors
+ for (Map.Entry<PTableKey, Long> entry :
+
tableRef.getTable().getAncestorLastDDLTimestampMap().entrySet()) {
innerBuilder =
RegionServerEndpointProtos.LastDDLTimestampRequest.newBuilder();
- PTableKey key = new PTableKey(conn.getTenantId(),
- tableRef.getTable().getParentName().getString());
- PTable parentTable = conn.getTable(key);
- setLastDDLTimestampRequestParameters(innerBuilder,
conn.getTenantId(), parentTable);
+ PTable ancestorTable = conn.getTable(entry.getKey());
Review Comment:
Yeah I was thinking if we can store both table name and schema name
separately in PTableKey when creating a PTableKey?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
