tkhurana commented on code in PR #1807:
URL: https://github.com/apache/phoenix/pull/1807#discussion_r1476502474
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -898,9 +898,9 @@ public MetaDataMutationResult updateCache(PName tenantId,
List<String> functionN
* @return true if the PTable contained by result was modified and false
otherwise
* @throws SQLException if the physical table cannot be found
*/
- private boolean addColumnsAndIndexesFromAncestors(MetaDataMutationResult
result, Long resolvedTimestamp,
- boolean
alwaysAddAncestorColumnsAndIndexes,
- boolean
alwaysHitServerForAncestors)
+ private boolean
addColumnsIndexesAndLastDDLTimestampsFromAncestors(MetaDataMutationResult
result, Long resolvedTimestamp,
Review Comment:
How does it handle view indexes in that case @palashc ? I am assuming if
this method is called for all types of index.
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -898,9 +898,9 @@ public MetaDataMutationResult updateCache(PName tenantId,
List<String> functionN
* @return true if the PTable contained by result was modified and false
otherwise
* @throws SQLException if the physical table cannot be found
*/
- private boolean addColumnsAndIndexesFromAncestors(MetaDataMutationResult
result, Long resolvedTimestamp,
- boolean
alwaysAddAncestorColumnsAndIndexes,
- boolean
alwaysHitServerForAncestors)
+ private boolean
addColumnsIndexesAndLastDDLTimestampsFromAncestors(MetaDataMutationResult
result, Long resolvedTimestamp,
Review Comment:
How does it handle view indexes in that case @palashc ? I am assuming this
method is called for all types of index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
