haridsv commented on code in PR #2041:
URL: https://github.com/apache/phoenix/pull/2041#discussion_r1886272707
##########
phoenix-core/src/test/java/org/apache/phoenix/schema/PMetaDataImplTest.java:
##########
@@ -198,6 +216,37 @@ public void testSchema() throws Exception {
}
}
+ @Test
+ public void testGetTableRefOptimized() throws Exception {
Review Comment:
I would name this `testGetTableRefOptimizationForMultitenancy`.
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/PMetaData.java:
##########
@@ -29,6 +29,7 @@ public static interface Pruner {
}
public int size();
public PTableRef getTableRef(PTableKey key) throws TableNotFoundException;
+ public PTableRef getTableRefOptimized(PTableKey key);
Review Comment:
The optimization here is not about not throwing TNFE, rather it is in
selection of right method (the new code `PhoenixConnection`). I would call this
`getTableNoTNFE` to reflect this fact. I would also rename
`getTableRefOptimized` to just `getTableRefNoTNFE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
