haridsv commented on code in PR #2041:
URL: https://github.com/apache/phoenix/pull/2041#discussion_r1886498820
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/PMetaData.java:
##########
@@ -29,6 +29,7 @@ public static interface Pruner {
}
public int size();
public PTableRef getTableRef(PTableKey key) throws TableNotFoundException;
+ public PTableRef getTableRefOptimized(PTableKey key);
Review Comment:
I think we are both saying the same thing, the optimization is about method
selection, but my point is that the new method is just a variant that
facilitates this optimization but not directly addressing the optimization
itself. The optimization comes from the use case, e.g., say you have a use case
that calls the same method but converts the `null` to TNFE (basically what the
existing getTableRef does, but now this is the application logic), now this new
application code won't be optimized just because it is using this new method.
Not the best argument possible, but I hope it conveys the meaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
