tkhurana commented on code in PR #2064:
URL: https://github.com/apache/phoenix/pull/2064#discussion_r1930994500
##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java:
##########
@@ -508,11 +534,17 @@ public void testMetricsForUpsert() throws Exception {
assertEquals("Zero failed mutations expected", 0,
metricValue);
mutationBatchFailedPresent = true;
}
+ else if
(metricType.equals(MetricType.MUTATION_BATCH_SUCCESS_COUNTER)) {
+ assertTrue("Mutation batch success count should be greater
than zero",
+ metricValue > 0);
Review Comment:
You can do a much tighter check here by checking for the exact value of
mutation batches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
